From 0ce675d00d77c97c74023064d69b0a36cd01c428 Mon Sep 17 00:00:00 2001
From: Quantum <quantum2048@gmail.com>
Date: Tue, 29 Oct 2024 21:04:39 -0400
Subject: [PATCH] Optimize is_aspa_invalid_upstream in bird

---
 aspa/validate.py | 4 ++--
 filter_aspa.conf | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/aspa/validate.py b/aspa/validate.py
index 956b82b..05dbc75 100644
--- a/aspa/validate.py
+++ b/aspa/validate.py
@@ -87,10 +87,10 @@ class BirdValidator(Validator):
                 if self.is_invalid_pair(asn, prev_asn) and max_up_ramp > i:
                     max_up_ramp = i
 
-                if self.is_invalid_pair(prev_asn, asn) and min_down_ramp < i:
+                if self.is_invalid_pair(prev_asn, asn):
                     min_down_ramp = i
 
             prev_asn = asn
-            i += 1
+            i = i + 1
 
         return min_down_ramp > max_up_ramp
diff --git a/filter_aspa.conf b/filter_aspa.conf
index 38ac5fd..4176074 100644
--- a/filter_aspa.conf
+++ b/filter_aspa.conf
@@ -34,7 +34,7 @@ function is_aspa_invalid_upstream() {
             if is_aspa_invalid_pair(cur_asn, cur_asn) && max_up_ramp > i then
                 max_up_ramp = i;
 
-            if is_aspa_invalid_pair(prev_asn, cur_asn) && min_down_ramp < i then
+            if is_aspa_invalid_pair(prev_asn, cur_asn) then
                 min_down_ramp = i;
         }